Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max number of auth rules constraint #1019

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

guicassolato
Copy link
Contributor

Closes #566

Signed-off-by: Guilherme Cassolato <guicassolato@gmail.com>
@guicassolato guicassolato self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (cc1b41f) to head (83376b9).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
+ Coverage   76.15%   83.79%   +7.64%     
==========================================
  Files         111       81      -30     
  Lines        8986     6628    -2358     
==========================================
- Hits         6843     5554    -1289     
+ Misses       1852      861     -991     
+ Partials      291      213      -78     
Flag Coverage Δ
bare-k8s-integration 15.95% <ø> (+5.07%) ⬆️
controllers-integration 76.34% <ø> (+17.48%) ⬆️
envoygateway-integration 40.97% <ø> (+8.47%) ⬆️
gatewayapi-integration 16.36% <ø> (+2.92%) ⬆️
istio-integration 43.54% <ø> (+9.21%) ⬆️
unit 17.04% <ø> (-8.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.61% <91.76%> (+2.18%) ⬆️
Files with missing lines Coverage Δ
api/v1/authpolicy_types.go 87.81% <ø> (ø)

... and 22 files with indirect coverage changes

@Boomatang Boomatang added the kind/bug Something isn't working label Nov 14, 2024
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked apply large authpolicy that failed on main. Working as expected.

@maleck13
Copy link
Collaborator

Will mege as I know @guicassolato is away

@maleck13 maleck13 merged commit 5e9176b into main Nov 14, 2024
32 checks passed
@guicassolato guicassolato deleted the fix/566-max-num-auth-rules branch November 14, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Lowered limit for AuthPolicy rules section
3 participants