Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: auth authzd/spicedb #1042

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Nov 21, 2024

Description

Part of Kuadrant/docs.kuadrant.io#25

Introduces an AuthPolicy guide describing how an authpolicy can be integrated with spicedb for permission requests.
This can serve as an equivalent / replacement guide to https://github.com/Kuadrant/authorino/blob/main/docs/user-guides/authzed.md guide on https://docs.kuadrant.io/0.11.0/authorino/docs/user-guides/authzed/

Verification

  • Running through the guide should work as expected

@KevFan KevFan self-assigned this Nov 21, 2024
@KevFan KevFan added the area/doc Improvements or additions to documentation label Nov 21, 2024
@KevFan KevFan force-pushed the guide-authzed branch 2 times, most recently from d42bc4f to c164ae2 Compare November 21, 2024 12:13
@KevFan KevFan marked this pull request as ready for review November 21, 2024 13:09
@KevFan KevFan requested a review from a team December 2, 2024 11:30
Boomatang
Boomatang previously approved these changes Jan 8, 2025
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, guide works as expected. I didn't spot any wrong with the grammar, but I am poor at that.

@Boomatang
Copy link
Contributor

@R-Lawton When your here, I am reviewing a different up date and a I remember seeing something about rolling the installation guides into one. Sadly, I can seem to find right now. I think you were the author. There is reference to those guides here. What impact would that have?

@Boomatang Boomatang dismissed their stale review January 8, 2025 12:50

Other required changes was spoted that I was unaware of.

Copy link
Contributor

@R-Lawton R-Lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things i noticed

@R-Lawton
Copy link
Contributor

R-Lawton commented Jan 8, 2025

@R-Lawton When your here, I am reviewing a different up date and a I remember seeing something about rolling the installation guides into one. Sadly, I can seem to find right now. I think you were the author. There is reference to those guides here. What impact would that have?

The docs that have currently been rolled into one where the SCP docs that's now just the one no matter what env you install on. The other installation docs have been rewritten to remove old obsolete things like operator hub in favour of helm and don't include certain things like setting up gateways etc. The idea is the docs work on any installation method that's not developer methods i.e make targets

Signed-off-by: KevFan <chfan@redhat.com>
Signed-off-by: KevFan <chfan@redhat.com>
Signed-off-by: KevFan <chfan@redhat.com>
Signed-off-by: KevFan <chfan@redhat.com>
Signed-off-by: KevFan <chfan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants