Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable build image trigger based on tags with -rc suffix #1105

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Jan 10, 2025

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@eguzki eguzki requested a review from maleck13 January 10, 2025 13:52
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (218eebd) to head (cbf6dea).
Report is 4 commits behind head on release-v1.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-v1.0    #1105      +/-   ##
================================================
+ Coverage         83.77%   84.10%   +0.32%     
================================================
  Files                81       81              
  Lines              6693     6693              
================================================
+ Hits               5607     5629      +22     
+ Misses              867      849      -18     
+ Partials            219      215       -4     
Flag Coverage Δ
bare-k8s-integration 15.79% <ø> (-0.04%) ⬇️
controllers-integration 76.36% <ø> (+0.21%) ⬆️
envoygateway-integration 40.75% <ø> (+0.01%) ⬆️
gatewayapi-integration 16.17% <ø> (ø)
istio-integration 43.74% <ø> (-0.16%) ⬇️
unit 19.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <ø> (ø)
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (ø)
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (ø)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 87.04% <ø> (+0.31%) ⬆️

see 9 files with indirect coverage changes

@eguzki
Copy link
Contributor Author

eguzki commented Jan 10, 2025

The verify bundle test error is due to the missing make/release.mk. Without the release file, the content of the bundle manifests and the (default) versions set on the Makefile do not match, hence the error.

@eguzki eguzki merged commit c567181 into release-v1.0 Jan 10, 2025
31 of 33 checks passed
@eguzki eguzki deleted the fix-build-images-for-tag-release-workflow branch January 10, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants