Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing space in quickstart script #412

Merged

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Jan 31, 2024

Had not seen this error before but when curling the script I get an error from the missing whitespace:

export KUADRANT_REF=v0.6.1
curl "https://raw.githubusercontent.com/kuadrant/kuadrant-operator/${KUADRANT_REF}/hack/quickstart-setup.sh" | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5620  100  5620    0     0  53047      0 --:--:-- --:--:-- --:--:-- 53523
bash: line 29: [: missing `]'

Fortunately does not affect the logic or running of the quickstart script as the check later is an if else on ISTIO_INSTALL_SAIL=true

@adam-cattermole adam-cattermole requested a review from a team as a code owner January 31, 2024 16:04
@adam-cattermole adam-cattermole force-pushed the quickstart-missing-space branch from 8f28516 to 9916741 Compare January 31, 2024 16:05
@adam-cattermole adam-cattermole self-assigned this Jan 31, 2024
@adam-cattermole adam-cattermole added kind/bug Something isn't working size/small labels Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Merging #412 (9916741) into main (e76cd28) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files          38       38           
  Lines        3901     3901           
=======================================
  Hits         2585     2585           
  Misses       1129     1129           
  Partials      187      187           
Flag Coverage Δ
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 71.39% <ø> (ø)

@adam-cattermole adam-cattermole merged commit 451cabd into Kuadrant:main Feb 1, 2024
15 checks passed
@adam-cattermole adam-cattermole deleted the quickstart-missing-space branch February 1, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants