-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gateway API to v1.1 #780
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
==========================================
+ Coverage 80.20% 82.28% +2.07%
==========================================
Files 64 77 +13
Lines 4492 6126 +1634
==========================================
+ Hits 3603 5041 +1438
- Misses 600 721 +121
- Partials 289 364 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1803396
to
760fe6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me
/lgtm |
@adam-cattermole I think it would be worth checking the quick start docs and docs repo also to see do we refer to installing a particular version of Gateway API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after your explanation regarding LocalPolicyTargetReference
that is the reason for removing the namespace tests. You'll need to rebase with main tho. 🥧
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
760fe6f
to
72c5c53
Compare
@@ -1,39 +1,39 @@ | |||
module github.com/kuadrant/kuadrant-operator | |||
|
|||
go 1.22 | |||
go 1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as of 1.22 the toolchain
directive is added if the go version is not specific. I.e. if I run go mod tidy
with go version 1.22.5 it updates the go.mod to the following:
go 1.22.0
toolchain go1.22.5
The only way to avoid is adding the full version afaict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL this. Thanks.
Changes
LocalPolicyTargetReference
Resolves #732, resolves #705