-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to Cross-Compilation for faster Docker Build Times #790
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 80.20% 81.89% +1.68%
==========================================
Files 64 76 +12
Lines 4492 6114 +1622
==========================================
+ Hits 3603 5007 +1404
- Misses 600 755 +155
- Partials 289 352 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…for the Quay.io Kuadrant Operator Registry Added sign-off Signed-off-by: dlaw4608 <dlawton@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase issue? I dont think this file and the files changes in tests/common/dnspolicy
should be part of this PR 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I must have squashed @makslion's commit into my own, will fix.
closes #787
This pull request introduces significant improvements to the Docker build process by implementing cross-compilation.
Building arm64 image via QEMU takes over 15 mins on github actions, making it slow to build for development.
Building the image via cross compile dropped this build time to 2 min 30
Changes Made
Dockerfile Updates:
ARG TARGETARCH
.--platform=$BUILDPLATFORM
for multi-platform builds with Docker Buildx.Workflow File:
Benefits