-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use API to generate EPs and remove OCM support #799
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
+ Coverage 80.20% 81.13% +0.92%
==========================================
Files 64 89 +25
Lines 4492 6879 +2387
==========================================
+ Hits 3603 5581 +1978
- Misses 600 881 +281
- Partials 289 417 +128
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d4e6ae5
to
c87d0b7
Compare
73a4f05
to
f485d2d
Compare
4bf1137
to
f150967
Compare
ebcd109
to
77149b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to use the builder looks good, but the change to the tests are unrelated and make me uncertain about possible regressions.
If you want to proceed with the proposed test changes I'd move them to a different PR so we can be sure the current tests all pass with the changes this PR is introducing.
77149b7
to
c8c15e4
Compare
Moved test changes into #882 so it could be discussed and closed or merged independently to this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Signed-off-by: Maskym Vavilov <mvavilov@redhat.com>
c8c15e4
to
1c1005c
Compare
Use a new API from
dns-operator
and remove all multicluster stuff