Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API to generate EPs and remove OCM support #799

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

maksymvavilov
Copy link
Contributor

Use a new API from dns-operator and remove all multicluster stuff

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (ece13e8) to head (1c1005c).
Report is 194 commits behind head on main.

Files with missing lines Patch % Lines
controllers/dnspolicy_dnsrecords.go 84.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   80.20%   81.13%   +0.92%     
==========================================
  Files          64       89      +25     
  Lines        4492     6879    +2387     
==========================================
+ Hits         3603     5581    +1978     
- Misses        600      881     +281     
- Partials      289      417     +128     
Flag Coverage Δ
bare-k8s-integration 6.84% <0.00%> (?)
controllers-integration 72.89% <88.23%> (?)
envoygateway-integration 49.78% <0.00%> (?)
gatewayapi-integration 12.52% <0.00%> (?)
integration ?
istio-integration 53.74% <0.00%> (?)
unit 28.46% <0.00%> (-1.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 84.61% <100.00%> (+13.18%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 70.95% <ø> (-2.96%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 82.48% <80.83%> (+5.68%) ⬆️
Files with missing lines Coverage Δ
controllers/dns_helper.go 92.30% <100.00%> (+8.32%) ⬆️
controllers/dnspolicy_dnsrecords.go 64.22% <84.00%> (-1.47%) ⬇️

... and 39 files with indirect coverage changes

@maksymvavilov maksymvavilov linked an issue Sep 6, 2024 that may be closed by this pull request
@maksymvavilov maksymvavilov marked this pull request as ready for review September 27, 2024 09:58
@maksymvavilov maksymvavilov changed the title [wip] use API to generate EPs and remove OCM Use API to generate EPs and remove OCM Sep 27, 2024
@maksymvavilov maksymvavilov changed the title Use API to generate EPs and remove OCM Use API to generate EPs and remove OCM support Sep 27, 2024
Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to use the builder looks good, but the change to the tests are unrelated and make me uncertain about possible regressions.

If you want to proceed with the proposed test changes I'd move them to a different PR so we can be sure the current tests all pass with the changes this PR is introducing.

@maksymvavilov
Copy link
Contributor Author

The changes to use the builder looks good, but the change to the tests are unrelated and make me uncertain about possible regressions.

If you want to proceed with the proposed test changes I'd move them to a different PR so we can be sure the current tests all pass with the changes this PR is introducing.

Moved test changes into #882 so it could be discussed and closed or merged independently to this change

Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Signed-off-by: Maskym Vavilov <mvavilov@redhat.com>
@maksymvavilov maksymvavilov merged commit d053ba5 into main Sep 27, 2024
31 checks passed
@maksymvavilov maksymvavilov deleted the gh-187 branch September 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove ACM Tests from kuadrant-operator API to generate DNSRecord endpoints for a given strategy and Gateway
2 participants