Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 "replaces" from bundle #892

Merged
merged 2 commits into from
Oct 1, 2024
Merged

🔥 "replaces" from bundle #892

merged 2 commits into from
Oct 1, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 1, 2024

For OLM from custom catalogs, replaces does not make sense as the catalog has only one bundle.

For OLM from public catalogs, we switched recently to semver-mode, so the "replaces" are automatically computed by OLM https://github.com/k8s-operatorhub/community-operators/pull/5074/files#diff-065802dd933715bcbb9102cf0ec632f16e00b47c9aafda66865c08e3c00fbda2R1

Helm charts not affected (AFAICT)

In conclusion, no need for replaces field. 🔥 to it.

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@eguzki eguzki requested a review from didierofrivia October 1, 2024 07:46
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (ece13e8) to head (3b0ca98).
Report is 197 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   80.20%   81.24%   +1.03%     
==========================================
  Files          64       89      +25     
  Lines        4492     6899    +2407     
==========================================
+ Hits         3603     5605    +2002     
- Misses        600      879     +279     
- Partials      289      415     +126     
Flag Coverage Δ
bare-k8s-integration 6.82% <ø> (?)
controllers-integration 72.95% <ø> (?)
envoygateway-integration 49.54% <ø> (?)
gatewayapi-integration 12.60% <ø> (?)
integration ?
istio-integration 53.39% <ø> (?)
unit 28.61% <ø> (-1.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 84.61% <100.00%> (+13.18%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 71.51% <ø> (-2.40%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 82.62% <82.51%> (+5.82%) ⬆️

see 49 files with indirect coverage changes

Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧨

@eguzki eguzki merged commit 94e7f83 into main Oct 1, 2024
31 checks passed
@eguzki eguzki deleted the remove-replaces-from-bundle branch October 1, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants