Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify release process #109

Merged
merged 1 commit into from
Jan 27, 2025
Merged

simplify release process #109

merged 1 commit into from
Jan 27, 2025

Conversation

eguzki
Copy link
Collaborator

@eguzki eguzki commented Jan 24, 2025

No description provided.

@eguzki eguzki added the enhancement New feature or request label Jan 24, 2025
@eguzki eguzki requested a review from jasonmadigan January 24, 2025 13:31
@eguzki eguzki linked an issue Jan 24, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.57%. Comparing base (7296e1b) to head (9c811a8).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
cmd/version.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #109       +/-   ##
==========================================
+ Coverage   0.38%   54.57%   +54.19%     
==========================================
  Files         17       17               
  Lines        783      885      +102     
==========================================
+ Hits           3      483      +480     
+ Misses       780      330      -450     
- Partials       0       72       +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@eguzki eguzki force-pushed the 108-wrong-version-number branch from 57ec060 to 9c811a8 Compare January 24, 2025 13:34
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should address a few open issues

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eguzki eguzki merged commit 0717a99 into main Jan 27, 2025
10 checks passed
@eguzki eguzki deleted the 108-wrong-version-number branch January 27, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong version number
4 participants