Skip to content

Commit

Permalink
Add a pick first rule. (#105)
Browse files Browse the repository at this point in the history
NOTE(kudo): sometimes cmake will bundle linked dependencies. when the issue happens, there are build errors like this:

```
Execution failed for task ':react-native-v8:mergeReleaseNativeLibs'.
> A failure occurred while executing http://com.android.build.gradle.internal.tasks.MergeJavaResWorkAction
   > 2 files found with path 'lib/arm64-v8a/libv8android.so' from inputs:
      - /path/to/app/android/node_modules/react-native-v8/android/build/intermediates/merged_jni_libs/release/out
      - /path/to/app/android//node_modules/react-native-v8/android/build/intermediates/cmake/release/obj
```

since the error happens inside react-native-v8 where it under our control, it's safe to pick any libv8android.so.

Co-authored-by: Rohit Tyagi <rtyagi@anar.biz>
  • Loading branch information
awesome31 and tyagiro3101 authored May 18, 2022
1 parent fef6bf1 commit d0a4f97
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ android {
"**/libglog.so",
"**/libreactnativejni.so",
]
pickFirst "**/libv8android.so"
}
configurations {
extractHeaders
Expand Down

0 comments on commit d0a4f97

Please sign in to comment.