[plugin] fix support on expo sdk 49 (rn 0.72) #187
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
added a commit
that referenced
this pull request
Jul 6, 2023
# Why follow up #187 # How add the missing the hermes-android # Test Plan try the reproducible example from expo/expo#23312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
the current plugin breaks on expo sdk 49 (react-native 0.72) because RNGP will exclude the libhermes.so when hermesEnabled=true
expo-dev-menu requires the hermes in debug build because it does not support v8
How
update the variant to keep libhermes.so
Test Plan
try the reproducible example from expo/expo#23312