This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add niceAgentIceTcp configuration option and API methods for it #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
Currently,
ice-tcp
is not explicitly set in Kurento's NiceAgent usage; therefore, it defaults toTRUE
(libnice's default) and always does TCP candidate gathering.Property reference: https://libnice.freedesktop.org/libnice/NiceAgent.html#NiceAgent--ice-tcp
What is the new behavior provided by this change?
The rationale behind this is to give the ability to deactivate TCP candidate gathering in setups where they aren`t needed, thus potentially speeding up the gathering process/connectivity checks and trimming down the number of generated candidates/bound sockets.
From the WebRtcEndpoint.conf.ini:
A pair of API methods was also added to be able to control this per element:
WebRtcEndpoint.setNiceAgentIceTcp(true|false)
WebRtcEndpoint.getNiceAgentIceTcp
How has this been tested?
Types of changes
Checklist