This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add externalIPv4/externalIPv6 configs and API methods for them #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
Currently,
externalAddress
allows only for a single IP that will be either IPv4 or IPv6. That's not friendly with dual stack IPv4+IPv6 environments.Fixes Kurento/bugtracker#522
What is the new behavior provided by this change?
This pull request splits the
externalAddress
config into two new onesexternalIPv4
externalIPv6
They can be used concurrently and will mangle compatible IPv_X candidates.
externalAddress
will still have precedence of these two new options: if it's set,externalIPv4/externalIPv6
will be ignoredFrom the
WebRtcEndpoint.conf.ini
explanation:How has this been tested?
Types of changes
Checklist