Added more flexibility #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but simple create a view to place above the pdf page.
…doing multi-lined search marks etc. More bugs may be found.
…wline search marks, correct positioning of the marks etc.
|
I've downloaded your version, and I get this error sometime : unable load adobe_glyphs from resource ... Thanks in advance for your answer |
hemangshah
approved these changes
May 31, 2017
|
Hi @kenneth488, as @KurtCode did never merge your changes into the branch and for now his code has changed so much, that it is not possible to merge your diffs into the current master: Thanks and regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi KurtCode
I have made some changes to the library, giving the user more freedom when it comes to the selections.
Redrawing the PDF page each time we search is not a good way to do it. Especially not if we are dealing with heavy files. Therefore giving the user the ability to draw the PDF page one time, and the freely placing the search marks on top gives a great amount of flexibility.
As mentioned in the readme I have restructured. I have implemented a method for only getting the page text, and one for getting the selections. The user only needs to call the selections "frame" method, convert the returned rect to userspace and place the view.
Regards,
Kenneth