Update solution.py #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i have added exception handling also try to reduce the number of operations
It's great having you contribute to this projectThank you for opening a Pull Request 🙌 , Welcome to SkillShow 💖 We will review everything and get back to you :) |
Kushal997-das
approved these changes
Oct 22, 2024
Kushal997-das
added
the
Approved✅
|
@mrsandy1965 Hurray, your PR got merged into our Skill-Show 🥳. Thanks a bunch. Feel free to take another Issue. 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have added exception handling also try to reduce the number of operations
SkillShow! 🎊🎈
Welcome! 🎉
Thank you for visiting our repository! We're excited to have you here. If you find this project useful, please consider giving it a star! ⭐
🎉 Have you reviewed the Contributing Guidelines? 🤔 (Required)
📝 Description
Following are the changes made :
1.Function Encapsulation: The code is wrapped in a function check_password_strength() to promote reusability and better organization.
2.Error Handling:Added a check for empty passwords, raising a ValueError if the input is empty.
Used try-except blocks to catch and handle specific exceptions, providing user-friendly error messages.
3.Optimized Character Checks:Utilized Python's built-in string methods (isupper(), islower(), isdigit(), and isalnum()) with generator expressions to check for character types. This approach is more Pythonic and improves readability.
4.Simplified Logic:The logic for determining password strength is streamlined, reducing redundancy and improving clarity.
5.Clearer Conditions:The conditions for determining password strength are clearer and more concise, making it easier to understand the flow of the program.
By implementing these changes, the password strength checker becomes more robust, user-friendly, and efficient. It can now handle various edge cases while providing clear feedback to the user.
🔧 Fixes #issue_no #4
🏷️ Initiative Participation (Required)
This pull request is associated with the following initiative. Please choose the one you are contributing to: