Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): add webhook to mutate pod #34

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat(webhook): add webhook to mutate pod #34

merged 1 commit into from
Feb 1, 2024

Conversation

Wenfeng-GAO
Copy link
Collaborator

Refs: #24

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Wenfeng-GAO Wenfeng-GAO changed the title feat(webhook): add webhook to mutate pod [wip] feat(webhook): add webhook to mutate pod Jan 19, 2024
pkg/webhook/add_pod.go Outdated Show resolved Hide resolved
@Wenfeng-GAO Wenfeng-GAO changed the title [wip] feat(webhook): add webhook to mutate pod feat(webhook): add webhook to mutate pod Jan 30, 2024
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
@Wenfeng-GAO Wenfeng-GAO force-pushed the hengzhuo-br branch 3 times, most recently from 9eb063f to 9e1b456 Compare February 1, 2024 09:21
@Wenfeng-GAO Wenfeng-GAO force-pushed the hengzhuo-br branch 2 times, most recently from 9c836dd to ea56dea Compare February 1, 2024 12:55
@zoumo
Copy link
Collaborator

zoumo commented Feb 1, 2024

LGTM

@zoumo zoumo merged commit 487d72e into main Feb 1, 2024
@zoumo zoumo deleted the hengzhuo-br branch February 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants