New (old?) feature - trade viewer

[tmakuch]

Hey @Kvan7,

I started to play again with EE2 by trying to add a new feature, just to learn backend is already there.

I've started to add a widget that will show you trade whispers in case you would miss some. Something like:

And it turns out the client log file is already being read and each line is parsed nicely with "MAIN->CLIENT::game-log" event and https://github.com/Kvan7/Exiled-Exchange-2/blob/master/renderer/src/web/client-log/client-log.ts#L38

Are there any plans to utilize this code or can I have a go at this with proposed feature? As far as I can tell, client logs are nicely parsed but then left unattended.

[Kvan7]

Interesting! I didn't know there was already had log parsing. I'm probably going to pass on this for now, I would personally rather work on making the price checking stuff better. I may come back to this later but probably not going to go core for now.

[tmakuch]

I have the feature working and for last few trade it seems to work fine.
Quick preview - https://youtu.be/HxfA54gZDLc (slide in effect was due to me alt+tab-ing to send myself a trade message, no animations were added).

In terms of what we actually got here:

• existing listener is already internationalized, so as long as ee2 language is set to the language of the game, the message will be handled,
• minimized view (item name + listed price) are displayed always on the screen (widget is not interactable and is click-through),
• opening ee2 overlay changes to full view, that allows you to interact with trade offer,
• paper plane icon -> adds "@sender " to chatbox, without sending it (@last is not used, so we don't care about order if there are multiple trades),
• invite icon -> /invite @sender + enter
• thumbs up icon -> @sender Thanks for trade! + enter (localized, I believe google translate was enough for such short text for other languages) + removes the whole entry from the list,
• close button in sender row -> remove specific senders from the list, if the list is empty whole entry is removed,
• close button above rows -> remove whole entry
• list of people wanting specific item is limited to 5 rows. You either get listed up to 5 people or 4 people and 'and X more' in last row.

In terms what could be added:

• some edge-case handling if you get lots of different offers (for different items, not from different people for the same item), for the moment the list just gets long. Problem here is that, in minimized view, item is not interactable, so any scroll does not make sense,
• some animation to catch your attention when in minimized mode? I'm a bit hasistant on this one, as it might just look bad,
• settings page. But (opinion) I don't feel like it needs to be customized. The whole idea is to have something on screen that you will not miss.

What I didn't get in, due to technical limitations:

• I wanted it to be more 'state' aware, i.e. not showing 'thanks' button until someone is invited to the party. Issue is, we do not get messages in the logs that would let me handle those moments. They are in the game chat window, but do not end up in the file that is being watched, thus, no message is catched.

So @Kvan7, opinions?

[Tronnic]

Can't wait for this to be added. With this, I could finally drop overwolf from my system and use EE exclusively. Thanks for your work!

[Kvan7]

Feel free to make a PR and I'll take a look at it. My current stance is still that stuff like Poe Lurker probably do similar operations, and since it is a dedicated program they have more dev time for specific functionality. I do have a couple concerns, I'll take a look at the PR and decide if they are actually relevant or not. My main concern is that I really don't have dev time to maintain another feature right now. This may get added but the PR may be open for a few days or a few months depending on how long it takes for me to get the price check to where I think I can call it good.

I myself am personally fine with the chat hotkeys, I don't really get enough whispers to need a dedicated trade macro, so that is kinda where I am coming from when I was initially saying this may not go to core.

[tmakuch]

I admit it started as a 'I dont want to remember what hotkey I assigned to a message', but I got over that quite quickly. The main part for me now, is that I get a list of trade's I've missed while doing maps.

I understand that it takes some time from you for reviews and testing, but in terms of fixes or improvements to this feature I do plan to stick around and do them. So I don't plan to leave you alone on this one ;)

[tmakuch]

PR: #386
I'll update to latest dev tomorrow

[tmakuch]

Small offtop in terms of what can we do with code. Response to #375 (reply in thread)

Poe Lurker or Overwolf PoE Overlay 2 does exactly the same looking at their code.

Looking at Lurker code, it seems the events stayed the same and they're guessing in what state the trade is currently in.

An example trade looks like this, whole logs, including (but redacted) poe2 errors and global chat:

2025/01/29 14:59:31 109816656 3ef2336b [INFO Client 14308] @From penpe: Hi, I would like to buy your Apocalypse Curio, Sapphire listed for 90 exalted in Standard (stash tab "Small items"; position: left 12, top 1)
2025/01/29 14:59:40 109826328 3ef2336b [INFO Client 14308] : Trade accepted.
2025/01/29 14:59:52 109837796 3ef2336b [INFO Client 14308] : penpe has joined the area.
2025/01/29 14:59:54 109839562 93b1b556 [CRIT Client 14308] [RENDER] Shader uses incorrect vertex layout (...)
2025/01/29 14:59:54 109839578 93b1b556 [CRIT Client 14308] [RENDER] Shader uses incorrect vertex layout (...)
2025/01/29 14:59:54 109839640 93b1b556 [CRIT Client 14308] [RENDER] Shader uses incorrect vertex layout (...)
2025/01/29 14:59:54 109839750 93b1b556 [CRIT Client 14308] [RENDER] Shader uses incorrect vertex layout (...)
2025/01/29 14:59:58 109844187 3ef2336b [INFO Client 14308] $isohel: WTS 2 STELLAR AMULETS FOR 1 DIV
2025/01/29 15:00:09 109855296 3ef2336b [INFO Client 14308] : Trade accepted.
2025/01/29 15:00:11 109856718 3ef2336b [INFO Client 14308] @From penpe: Thank you WscieklyBorsuk! Have a nice day and good luck!
2025/01/29 15:00:13 109858562 3ef2336b [INFO Client 14308] @To penpe: Thanks for the trade!

My biggest issue at guessing is that I can not trust the "Trade accepted." - trading with a player and opening npc shop to dismantle uniques give the same line.