🎨🐍 Add specific parsers for domtblout and tblout for hmmscan output formats #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve outputs (tblout and domtblout) 🎨🐍 Updated markers filter to use updated parse read_tblout(...) func in hmmscan.py NOTE: read_tblout(...) and read_domtblout(...) now return pd.DataFrame with output-specific column names
evanroyrees
added
enhancement
🐛 First check if an outfpath was provided to filter_tblout_markers(...) before checking filepath stats
…ers(...) module function name was changed in unit_tests as well as commmon markers module
ajlail98
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placing this here in case anyone would like to add their thoughts.
hmmscancan output multiple formats, for exampleoutput.tbloutandoutput.domtblout. Previously the marker annotations parsed the tblout file format. However, the domtblout format contains more information that could be used to enhance the marker databases/filtering/annotation process. Happy to close this PR without a merge, but thought I would see if there was any interest in including this.