Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 🎨 🍏 Fix kingdom-handling and mounting NCBI databases into docker container #229

Merged
merged 12 commits into from
Jan 30, 2022

Conversation

evanroyrees
Copy link
Collaborator

  • 🐛🎨🐳🍏 Fix bug where NCBI databases are not mounted correctly by nextflow for the BINNING_SUMMARY process
  • 🐛🎨🍏 Fix bug where params.kingdom = "archaea" would not use archaeal contigs
  • 🎨🍏 Taxon assignment now emits all kingdoms causing all kingdom fastas to be published to the respective output directory

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #229 (755a61b) into dev (9a641b3) will increase coverage by 0.17%.
The diff coverage is 78.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #229      +/-   ##
==========================================
+ Coverage   27.36%   27.53%   +0.17%     
==========================================
  Files          45       45              
  Lines        5314     5331      +17     
==========================================
+ Hits         1454     1468      +14     
- Misses       3860     3863       +3     
Flag Coverage Δ
unittests 27.53% <78.12%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
autometa/binning/recursive_dbscan.py 84.42% <0.00%> (-1.35%) ⬇️
autometa/binning/unclustered_recruitment.py 91.93% <90.00%> (+0.13%) ⬆️
autometa/binning/summary.py 41.86% <100.00%> (ø)
autometa/common/kmers.py 88.53% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a641b3...755a61b. Read the comment docs.

🎨✅ Fix test for unclustered_recruitment.py
🎨🐛🍏🐍 Re-write unclustered recruitment features table to output-features and main to output-main
🎨🐍🐛 Incorrect cluster col usage in get_metabin_stats for binnin/summary.py
🎨🍏 Rename bin_contigs.nf to binning.nf
🎨🍏 Update tags for kmers, binning and recruitment
🎨🐍 Update kmers main behavior so kmer pipeline may be run at multiple different stages
🎨🍏 Update modules.config for new local kmer and binning processes
🔥✅ Remove unnecessary import
…binning.nf

✅ Add test for raising a TableFormatError
🍏 Add errorStrategy to binning.nf to ignore the 204 error
🐍🎨 Add sys.exit(204) exit code when raising a BinninError or TableFormatError for recursive_dbscan.py
@evanroyrees evanroyrees merged commit 1c0229d into dev Jan 30, 2022
@evanroyrees evanroyrees deleted the add-kingdoms branch January 30, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment