Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step by step walkthrough #314

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Step by step walkthrough #314

merged 1 commit into from
Apr 21, 2023

Conversation

kaw97
Copy link
Collaborator

@kaw97 kaw97 commented Mar 23, 2023 •
edited
Loading

closed old PR and opened new one to merge to dev, issue #304

@kaw97 kaw97 requested a review from chasemc March 23, 2023 21:46
@chasemc
Copy link
Member

chasemc commented Mar 27, 2023

See #315 (comment)

@Sidduppal Sidduppal self-requested a review April 21, 2023 15:23
@kaw97
updated tutorial
3da3f63 
explanation is now in the same order as the commands are input and deprecated --domain has been replaced with rank-filter-name
Sidduppal
Sidduppal approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Sidduppal Sidduppal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@WiscEvan and @chasemc
@kaw97 ran git rebase so that it's appropriately checked out from dev instead of main (which was done before). I think it looks good to me, can you guys confirm and merge?

@evanroyrees evanroyrees linked an issue Apr 21, 2023 that may be closed by this pull request
Documentation needs edit #304
Open
@evanroyrees evanroyrees merged commit 32f44d0 into KwanLab:dev Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidduppal Sidduppal Sidduppal approved these changes

@chasemc chasemc Awaiting requested review from chasemc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation needs edit
4 participants
@kaw97 @chasemc @Sidduppal @evanroyrees