Fix Issue#350 #353
Merged
Fix Issue#350 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Chage line_terminator to lineterminator in `summary.py`
|
The failing tests need to be fixed via updating to the new Biopython function for gc calculations (note the factor difference (biopython/biopython#4622 (comment))): "Function 'GC' in Bio.SeqUtils was deprecated in Release 1.80, and removed in Release 1.82. Instead use function 'gc_fraction'" https://github.com/biopython/biopython/blob/biopython-183/DEPRECATED.rst#biosequtils |
chasemc
reviewed
Feb 20, 2024
There was a problem hiding this comment.
May need to address this later but will merge for now
Sidduppal
added a commit
that referenced
this pull request
May 31, 2024
* 🎨 Add snakefile * 🔥 remove status-sacct.sh * Fix Issue#350 (#353) * Fix pandas version * :up-arrow: Update pandas to 1.5 🎨 Chage line_terminator to lineterminator in `summary.py` * Fix biopython error * Update bioython version * Fix ncbi_is_connected error (#352) * Update metagenome.py * Update metagenome.py * Update version * Remove snakemake workflow * Remove space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>=1.5.