Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NA issues after Pandas update #361

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix NA issues after Pandas update #361

merged 4 commits into from
Jun 14, 2024

Conversation

chasemc
Copy link
Member

@chasemc chasemc commented Jun 10, 2024

No description provided.

@chasemc
Copy link
Member Author

chasemc commented Jun 10, 2024

Related: #349

@Sidduppal
Copy link
Collaborator

Sidduppal commented Jun 10, 2024 •
edited
Loading

Looks good. Few points:

  • Please implement the changes for hbscan as well.
  • Update the version in VERSION and nextflow.config for the new release
  • Is dev upto date with main? I would do a pull before the merge.

@Sidduppal Sidduppal added the bug Something isn't working label Jun 10, 2024
@chasemc
Copy link
Member Author

chasemc commented Jun 10, 2024

I've spent as much time as I can on this and welcome anyone else to make the changes mentioned above. I already fast forwarded dev onto main

@Sidduppal
Copy link
Collaborator

In reference to

With this update I'm getting more and better clusters than the unit test data t
hat I have access to (we're looking to that in the meantime).

I ran binning (using dbscan) using the dev branch and v2.0.0 and the results are exactly the same. Files are attached for reference. I will do the same changes for hdbscan.

Archive.zip

@Sidduppal Sidduppal marked this pull request as ready for review June 14, 2024 17:21
@chasemc
Copy link
Member Author

chasemc commented Jun 14, 2024

Fixes #349

@Sidduppal Sidduppal merged commit 0d9028c into main Jun 14, 2024
7 of 9 checks passed
@Sidduppal Sidduppal mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidduppal Sidduppal Sidduppal approved these changes

@jason-c-kwan jason-c-kwan Awaiting requested review from jason-c-kwan

@shaneroesemann shaneroesemann Awaiting requested review from shaneroesemann

Assignees

@chasemc chasemc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chasemc @Sidduppal