Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge nodes when databases out of sync. #9

Merged
merged 4 commits into from
Mar 2, 2020

Conversation

evanroyrees
Copy link
Collaborator

This issue has since been resolved in the refactored version. This is a hotfix to master.

The error occurs when the nr.dmnd database search and prot.accession2taxid.gz recovers taxids different from the tree structure within nodes.dmp. This is easily resolved as NCBI has similarly provided a merged.dmp file with the old to new taxid translations.

# The below method will translate any old taxids otherwise the assigned taxid will be used.
taxid = merged.get(taxid,taxid)

@evanroyrees evanroyrees added the bug Something isn't working label Feb 20, 2020
@jason-c-kwan
Copy link
Collaborator

I didn't see any code that downloads merged.dmp. Am I missing something?

@evanroyrees
Copy link
Collaborator Author

The merged.dmp file is now also extracted with nodes.dmp and names.dmp

@jason-c-kwan jason-c-kwan merged commit faf8243 into KwanLab:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants