Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank-specific binning #96

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Rank-specific binning #96

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
908fbc4
:art: Add taxonomy specific splitting control
evanroyrees Jun 21, 2020
4fad3b2
Merge branch 'dev' of https://github.com/KwanLab/Autometa into rank-b…
evanroyrees Jun 23, 2020
322e1f1
:memo: Update --reverse-ranks parameter help text
evanroyrees Jun 23, 2020
6078aca
:memo: Update help text for --reverse-ranks parameter
evanroyrees Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions autometa/binning/recursive_dbscan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,8 @@ def main():
"--reverse-ranks",
action="store_true",
default=False,
help="Reverse canonical-rank taxonomy splitting"
" from superkingdom -> species to species -> superkingdom",
help="Reverse order at which to split taxonomy by canonical-rank."
" Contigs will be split in order of species, genus, family, order, class, phylum, superkingdom.",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not completely clear. I think you will find users asking you exactly what order is --reverse-ranks and which is not.

Suggested change
help="Reverse order at which to split taxonomy by canonical-rank."
" Contigs will be split in order of species, genus, family, order, class, phylum, superkingdom.",
)
help="Reverse order at which to split taxonomy by canonical-rank."
"When --reverse-ranks given, contigs will be split in order of species, genus, family, order, class, phylum, superkingdom.",
)

parser.add_argument(
"--domain",
Expand Down