Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larry change requests #403

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Larry change requests #403

merged 8 commits into from
Aug 16, 2024

Conversation

Philip-Carneiro-KX
Copy link
Collaborator

@Philip-Carneiro-KX Philip-Carneiro-KX commented Aug 16, 2024

Changes introduced by this PR

Add a Connection

  • Move the Create Connection button from the upper right to the lower left on for all connection types.
  • When I create a new label, that label should then populate the dropdown after I click Save on the Add New Label modal.

Edit a Connection

  • Primary button name should be Update Connection, not Edit Connection and the button should be moved from the upper right to the lower left of the screen.
  • If I add a new label, the label gets added to the connection window when I click save from the modal window. This creates an issue if I decide to choose a different label before I save the edit as the label is already shown in the connection window. Can we add the label after the edit connection is saved and not when creating a new label?

Add a New Label

  • Can we do validation on the Create button as clicking this before I set both the name and color closes the modal and does nothing? It should not be actionable until I set both the name and color.

@kx-sonarqube
Copy link

kx-sonarqube bot commented Aug 16, 2024

@Philip-Carneiro-KX Philip-Carneiro-KX merged commit 28ed191 into dev Aug 16, 2024
5 checks passed
@Philip-Carneiro-KX Philip-Carneiro-KX deleted the larry-new-conn-requests branch August 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants