Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intergrate service maintain promotees list to tradelog v2 #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

intergrate service maintain promotees list to tradelog v2 #92

wants to merge 3 commits into from

Conversation

iostream1308
Copy link
Member

No description provided.

linhnt3400
linhnt3400 reviewed Oct 30, 2024
View reviewed changes
v2/pkg/app/server.go Outdated Show resolved Hide resolved
v2/pkg/handler/trade_logs.go Outdated Show resolved Hide resolved
v2/pkg/handler/trade_logs.go Outdated Show resolved Hide resolved
v2/pkg/handler/trade_logs_test.go Outdated Show resolved Hide resolved
v2/pkg/promotionparser/parser.go Outdated Show resolved Hide resolved
v2/pkg/storage/promotees/storage.go Outdated Show resolved Hide resolved
v2/pkg/storage/promotees/storage.go Outdated Show resolved Hide resolved
linhnt3400
linhnt3400 reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@linhnt3400 linhnt3400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forget to push the migration file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linhnt3400 linhnt3400 linhnt3400 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iostream1308 @linhnt3400