feat: support passive event listeners #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janczizikow
force-pushed
the
feat/passive-event-listeners
branch
from
368930f
to
3f1b2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for passive event listeners to improve scroll performance.
This PR is pretty much based of @undirectlookable's PR.
I thought it might be a good addition and the previous PR went spooky quiet, thus I opened this one.
The feature detection util function is taken from MDN.
Reference: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Improving_scrolling_performance_with_passive_listeners
P.S.:
window.removeEventListenercall incomponentWillUnmountlifecycle. I was wondering why it's there, since there's no other place where there'swindow.addEventListener. The only scenario I could think of is someone changing theparentprop to a function which returns different element from previous prop.