fix(typography): Prepend styles to <head> instead of placing them at end, possibly overwriting user styles #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KyleAMathews there's some noise here re: prettier. I can revert f235c11, but I'm sure you get the idea. Also looks like Travis fails in Node 6, but not related to the changes in this PR 🤷♂️ |
KyleAMathews
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Thanks Dustin! This might be a breaking change for some use cases — it's clearly not the expected behavior given the volume of bug reports we get on Gatsby about typography.js unexpectedly overwriting their styles — so let's change the typopgraphy.js styles to always be placed first in the head.
KyleAMathews
changed the title
|
Also added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to prepend with injectStyles.
I made this opt-in (with a boolean) so that the existing behavior will remain, unless explicitly tweaked. That being said--this seems like a fix for confusing behavior, so I'd be happy to make this the default if we're comfortable with potential breaking changes.