Return unescaped paths when searching for library files #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
|
Happy to help! Any chance we could get a |
|
Sure, I should have a release out in a few hours (going to look into a few more issues). |
|
Just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in #134 where
search_directoryreturned the escaped directory, which causes errors when it is later passed toFile::open.One can reproduce the issue by creating a project using
bindgenand settingLIBCLANG_PATHto a folder containing square brackets (e.g./path/to/[foo]bar).clang-sysis able to find the shared libraries inside the[foo]barfolder but is unable to actually load the files because the path becomes/path/to/[[]foo[]]bar/libclang.so.