Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH-158] Support functions for clickhouse backend: lower/upper/ltrim/rtrim #117

Merged

Conversation

taiyang-li
Copy link

@taiyang-li taiyang-li commented Sep 8, 2022

Changelog category (leave one):

  • Improvement

support more string functions, which close #158

  • lower
  • upper
  • ltrim
  • rtrim

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@taiyang-li taiyang-li changed the title support more functions Support functions for clickhouse backend: lower/upper/ltrim/rtrim Sep 14, 2022
@taiyang-li taiyang-li marked this pull request as draft September 15, 2022 12:16
@taiyang-li taiyang-li marked this pull request as ready for review September 16, 2022 03:36
@taiyang-li
Copy link
Author

Does anyone have time to review this PR, thanks!

utils/local-engine/Common/Logger.cpp Outdated Show resolved Hide resolved
utils/local-engine/Parser/SerializedPlanParser.cpp Outdated Show resolved Hide resolved
@liuneng1994
Copy link
Collaborator

test this please

Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 31a4432 into Kyligence:clickhouse_backend Sep 22, 2022
@taiyang-li taiyang-li changed the title Support functions for clickhouse backend: lower/upper/ltrim/rtrim [CH-158] Support functions for clickhouse backend: lower/upper/ltrim/rtrim Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clickhouse backends support ltrim/rtrim/lower/upper functions
3 participants