fixed a bug: coredump caused by transform a row batch with empty required columns into DB::Block
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lgbo-ustc
force-pushed
the
r2c_empty_cols
branch
from
b3ca528
to
0f78cf4
Compare
lgbo-ustc
force-pushed
the
r2c_empty_cols
branch
from
0f78cf4
to
4c92b56
Compare
|
test this please |
1 similar comment
|
test this please |
liuneng1994
reviewed
Oct 20, 2022
lgbo-ustc
force-pushed
the
r2c_empty_cols
branch
from
4c92b56
to
ff62961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the required columns could be empty in spark plan, and cause a coredump in SparkRowToCHColumn
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When there is no required columns in a row batch, we try to an anonymous const column in the result block of
SparkRowToCHColumn. This could happend in some cases. E.g count(*)This doesn't break the execution
close #140