Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH-259]fixed a bug related to count(1)/count(*) #260

Merged
merged 1 commit into from
Jan 11, 2023
Merged

[CH-259]fixed a bug related to count(1)/count(*) #260

merged 1 commit into from
Jan 11, 2023

Conversation

lgbo-ustc
Copy link

@lgbo-ustc lgbo-ustc commented Jan 10, 2023 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

Closes #259.

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@lgbo-ustc
Copy link
Author

test this please with 831

@lgbo-ustc lgbo-ustc mentioned this pull request Jan 11, 2023
Merged
liuneng1994
liuneng1994 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 037ffdf into Kyligence:clickhouse_backend Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure on test case Gluten count in GlutenDataFrameAggregateSuite
3 participants
@lgbo-ustc @kyligence-git @liuneng1994