Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[304] Print jvm stacktrace when the exception is caught in C++ #305

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[304] Print jvm stacktrace when the exception is caught in C++ #305

merged 1 commit into from
Feb 22, 2023

Conversation

lgbo-ustc
Copy link

@lgbo-ustc lgbo-ustc commented Feb 22, 2023 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

close #304

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@lgbo-ustc
Copy link
Author

test this please

@liuneng1994
Copy link
Collaborator

test this please

1 similar comment
@liuneng1994
Copy link
Collaborator

test this please

liuneng1994
liuneng1994 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 5928196 into Kyligence:clickhouse_backend Feb 22, 2023
@lgbo-ustc lgbo-ustc mentioned this pull request Mar 8, 2023
Closed
@shuai-xu shuai-xu mentioned this pull request Mar 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print jvm stacktrace when catch java exceptions in C++
3 participants
@lgbo-ustc @kyligence-git @liuneng1994