Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support function space #321

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Support function space #321

merged 1 commit into from
Mar 30, 2023

Conversation

KevinyhZou
Copy link

Changelog category (leave one):

  • New Feature
    Support function space

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

SELECT space(3);

Result:

┌─space(3) ────┐
│              │
└──────────────┘

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@KevinyhZou
Copy link
Author

KevinyhZou commented Mar 1, 2023 •
edited
Loading

the releated issue is: #320

the clickhouse releated pr: ClickHouse#47049

@KevinyhZou KevinyhZou mentioned this pull request Mar 1, 2023
Merged
@KevinyhZou KevinyhZou force-pushed the support_function_space branch 2 times, most recently from 5785f2d to 05139f2 Compare March 1, 2023 07:32
@KevinyhZou KevinyhZou marked this pull request as draft March 3, 2023 01:45
@KevinyhZou KevinyhZou marked this pull request as ready for review March 10, 2023 02:45
@liuneng1994
Copy link
Collaborator

test this please

liuneng1994
liuneng1994 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
Copy link
Collaborator

@KevinyhZou please resolve conflicts

@KevinyhZou
Copy link
Author

@KevinyhZou please resolve conflicts

done @liuneng1994

@liuneng1994
Copy link
Collaborator

test this please

@liuneng1994 liuneng1994 merged commit dcba13d into Kyligence:clickhouse_backend Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinyhZou @kyligence-git @liuneng1994