Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support lead/lag/dense_rank #322

Merged
merged 1 commit into from
Mar 1, 2023
Merged

support lead/lag/dense_rank #322

merged 1 commit into from
Mar 1, 2023

Conversation

lgbo-ustc
Copy link

@lgbo-ustc lgbo-ustc commented Mar 1, 2023 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

close #218

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@lgbo-ustc
Copy link
Author

test this please with 906

@lgbo-ustc lgbo-ustc mentioned this pull request Mar 1, 2023
Closed
liuneng1994
liuneng1994 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 4942797 into Kyligence:clickhouse_backend Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support window functions
4 participants
@lgbo-ustc @kyligence-git @liuneng1994 @zzcclp