Support full join with join condition #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please with 1164 |
1 similar comment
|
test this please with 1164 |
|
test this please with 1164 |
1 similar comment
|
test this please with 1164 |
liuneng1994
reviewed
Mar 20, 2023
| ASTPtr parseToAST(const Names & names, const substrait::Expression & rel); | ||
| void parseFunctionArgumentsToAST(const Names & names, const substrait::Expression_ScalarFunction & scalar_function, ASTs & ast_args); | ||
| ASTPtr parseArgumentToAST(const Names & names, const substrait::Expression & rel); | ||
| ActionsDAGPtr convertASTToActions(const NamesAndTypesList & name_and_types, const ASTPtr & ast); |
liuneng1994
reviewed
Mar 20, 2023
| pb_util::JsonOptions options; | ||
| std::string json; | ||
| pb_util::MessageToJsonString(rel, &json, options); | ||
| LOG_DEBUG(&Poco::Logger::get("SerializedPlanParser"), "substrait plan:{}", json); |
There was a problem hiding this comment.
这里是不是可以搞一个util函数专门做json的序列化
liuneng1994
reviewed
Mar 20, 2023
|
test this please with 1164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Support full join with join condition.
test by spark ut