Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH-364] Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit #377

Merged
merged 14 commits into from
Mar 29, 2023
Merged

[CH-364] Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit #377

merged 14 commits into from
Mar 29, 2023

Conversation

taiyang-li
Copy link

@taiyang-li taiyang-li commented Mar 24, 2023 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit(current not).
  • Make sure every correspoinding settings and configs are applied at JNI_Onload (current not).
  • Some refactor works.

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@taiyang-li taiyang-li changed the title Make sure global_context is initialized once at the first invoking and finalized once at exit [CH-364] Make sure global_context is initialized once at the first invoking and finalized once at exit Mar 24, 2023
@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li taiyang-li changed the title [CH-364] Make sure global_context is initialized once at the first invoking and finalized once at exit [CH-364] Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit Mar 24, 2023
@liuneng1994
Copy link
Collaborator

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

2 similar comments
@taiyang-li
Copy link
Author

test this please with 1143

@liuneng1994
Copy link
Collaborator

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

1 similar comment
@taiyang-li
Copy link
Author

test this please with 1143

@taiyang-li
Copy link
Author

test this please with 1143

liuneng1994
liuneng1994 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit ea4a475 into Kyligence:clickhouse_backend Mar 29, 2023
@taiyang-li taiyang-li deleted the fix_buildes_typo branch April 13, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taiyang-li @kyligence-git @liuneng1994