Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Support Decimal type in Gluten #378

Merged
merged 2 commits into from
Mar 29, 2023
Merged

[VL] Support Decimal type in Gluten #378

merged 2 commits into from
Mar 29, 2023

Conversation

loneylee
Copy link

Velox resize checkoverflow function args to 3.
Fix it.

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@loneylee loneylee mentioned this pull request Mar 24, 2023
Merged
@liuneng1994
Copy link
Collaborator

test this please

@loneylee
Copy link
Author

test this please with 1176

@loneylee
Copy link
Author

test this please with 1176

1 similar comment
@loneylee
Copy link
Author

test this please with 1176

zzcclp
zzcclp approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit ea45be8 into Kyligence:clickhouse_backend Mar 29, 2023
@loneylee loneylee deleted the 1176 branch March 30, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchengchenghh jinchengchenghh jinchengchenghh approved these changes

@zzcclp zzcclp zzcclp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loneylee @kyligence-git @liuneng1994 @zzcclp @jinchengchenghh