Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join key with alpha ASCII #390

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix join key with alpha ASCII #390

merged 1 commit into from
Mar 30, 2023

Conversation

loneylee
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Fix join key with alpha ASCII will accured assert

select * from
(select l_partkey as `中文` from lineitem where l_partkey='6731') t1
full join
(select l_partkey `中文`,l_shipinstruct from lineitem where l_partkey='6731') t2
on t1.`中文`=t2.`中文`

test by gluten ut

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

liuneng1994
liuneng1994 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit be666e8 into Kyligence:clickhouse_backend Mar 30, 2023
@loneylee loneylee deleted the keysame branch March 30, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loneylee @kyligence-git @liuneng1994