Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix size of ColumnBuffer not configurable #396

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

shuai-xu
Copy link

@shuai-xu shuai-xu commented Apr 3, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The buffer size of ColumnBuffer is now hard code to 8192, let it be the same as Option.buffer_size.

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 5d0e686 into Kyligence:clickhouse_backend Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants