Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UT of benchmark_local_engine.cpp #400

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Fix UT of benchmark_local_engine.cpp #400

merged 5 commits into from
Apr 10, 2023

Conversation

zhanglistar
Copy link

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

liuneng1994
liuneng1994 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
Copy link
Collaborator

test this please

liuneng1994
liuneng1994 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 3028f6b into Kyligence:clickhouse_backend Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhanglistar @kyligence-git @liuneng1994