[CH-402]Enable return null and complex type for get_json_object function #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
KevinyhZou
changed the title
This was referenced Apr 6, 2023
Closed
liuneng1994
reviewed
Apr 6, 2023
| if (function_name == "JSON_VALUE") | ||
| { | ||
| context->setSetting("function_json_value_return_type_allow_complex", true); | ||
| context->setSetting("function_json_value_return_type_allow_nullable", true); |
There was a problem hiding this comment.
为什么要在这个位置修改配置。。不可以在最开始的时候配置好吗。在解析计划的时候修改context似乎不太合理
liuneng1994
reviewed
Apr 6, 2023
| @@ -17,7 +17,7 @@ struct NativeAllocatorContext | |||
| { | |||
| std::shared_ptr<DB::CurrentThread::QueryScope> query_scope; | |||
| std::shared_ptr<DB::ThreadStatus> thread_status; | |||
| DB::ContextPtr query_context; | |||
| DB::ContextMutablePtr query_context; | |||
KevinyhZou
force-pushed
the
adapt_get_json_object
branch
from
8666231
to
03b43bb
Compare
|
Fixed done @liuneng1994 |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable return null and complex type for get_json_object function. By adapt to 2 settings
function_json_value_return_type_allow_nullableandfunction_json_value_return_type_allow_complexas introduced in pr : ClickHouse#47494. The issue is described in #402