-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify SessionToken to be compatible with Checkout UI Extension #329
Conversation
9b59acd
to
99bc6cd
Compare
@jeroendelau are you able to add a wiki page on how this would be use for the checkout extension vs the main laravel application? |
absolutely, I will try to get something in there before the end of the week. |
@jeroendelau great work on this. |
No, sorry, simply had no time. Will fix |
I think I fixed all linter issues, but I'm having trouble reproducing the same error locally. |
a6ddb7e
to
aae249e
Compare
Added in separate PR #346 The reason I couldn't get the linter to fail was because the local version does not match the version of github actions. github action 3.0.0 After setting composer to 3.0.0 the errors matched. Suggest adjusting the lint action to use the composer version so mismatch can't happen.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Checkout UI Extensions have session tokens, but they vary slightly from the token provided by Shopify Apps.
App Session Tokens
Checkout Extension Session Tokens
Key differences:
By merging this PR people should be able to use session tokens obtained through useSessionToken, to interact with the back-end without modification.