feat(nbt): Implement nameless binary serialization #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this could be more nicely implemented with the upcoming feature flag system coming soon:tm:? Since it's sorta a version-specific serialization quirk. |
5 tasks
|
So giving this more thought, with the changes I would like to see in #1009 being a bit too big to squish into 4.15.0, I think we're ok to take this design more or less as-is, and revision can occur in future versions. Thank you for your contribution! |
zml2008
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements serialization of nameless compound tags. Mojang has removed these already useless names in 23w31a (1.20.2 snapshot) and this adds API for reading/writing these "nameless" compound tags.
Not sure about how it is exposed, could also be solved by specifying a boolean for
read/writemethods