IconHelper leaves unsed API allocated memory #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your working with the Windows API is dirty. You don't frees API allocated memory. In description of ExtractIconEx states under "Remarks" you have to destroy the icons, that means calling DestroyIcon for each icon handle (your IntPtr's). I'm not familiar right now with GIT so I don't fix it in code, but introduces a "TODO" comment with links to the MSDN descriptions of both functions.
|
Thanks for your PR. I will check this out. |
|
Maybe I will remove this completely: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your working with the Windows API is dirty. You don't frees API allocated memory. In description of ExtractIconEx states under "Remarks" you have to destroy the icons, that means calling DestroyIcon for each icon handle (your IntPtr's).
I'm not familiar right now with GIT so I don't fix it in code, but introduces a "TODO" comment with links to the MSDN descriptions of both functions.