put b(binary) back infront of bytes join for better support of python3 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CodeFactor failed for something i did not change. |
L2jLiga
approved these changes
Aug 19, 2021
|
released as v4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #356 from
grunt-webfont. I'm not positive when in python3 this broke, but in later versions, say >=3.7, the scripts silently fails to create eot files. python2.7 ignores thebnotation, so that should not impact earlier versions. I've seen this in linux builds and recently in an osx build and we have validation that ensures all assets are built, so the build will fail if not on python2.7 or python3 (less than something, but i thought bytes were a big change for 3.0). This change ensures they are generated, i will look for tests in the repo to confirm this change passes.