3517 - Send reports to discord via celery task #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debeb35 we reverted the original implementation of the task as it broke the production environment. The problem was that celery tasks need objects that could be JSON serializable and we were passing a `Message` instance, so just passing the details fixed the issue.
nablabits
requested review from
andreaskoepf,
melvinebenezer and
yk
as code owners
|
Ok |
|
@nablabits : we can discuss on the automated tests in discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix: #3517
In debeb35 we reverted the original implementation of the task as it broke the production environment. The problem was that celery tasks need objects that could be JSON serializable and we were passing a
Messageinstance, so just passing the details fixed the issue.A few things that I noticed:
pre-commitversion pinned in the requirements.txt so I just used the latest one (3.3.3). In the past I had experienced issues with this so it might be a good idea to pin it.pytestor similar, if you consider so, I'm happy to write them and install the necessary libraries as eventually that will make the codebase more robust.