Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle logs #30

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Handle logs #30

merged 4 commits into from
Feb 3, 2022

Conversation

PHamacher
Copy link
Collaborator

  • Add Memento to handle logs
  • Throw an error instead of a warning when an element from the wrong type is read in the PWF file
  • Always read field 'OPERATION' as Char, in order to avoid the error mentioned in Generate error for ESS ImperatrizPS file in DBAR section #28
  • New parsing method, reading the PWF file based on line indexes
  • Inform the user in which line errors are occurring, using the new parsing method
  • Adjust tests to the new parsing method

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #30 (0fc5fb3) into develop (5e8a35e) will decrease coverage by 0.40%.
The diff coverage is 84.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
- Coverage    91.51%   91.11%   -0.41%     
===========================================
  Files           14       14              
  Lines         1061     1069       +8     
===========================================
+ Hits           971      974       +3     
- Misses          90       95       +5     
Impacted Files Coverage Δ
src/pwf2pm/branch.jl 87.31% <0.00%> (ø)
src/PWF.jl 36.36% <16.66%> (-23.64%) ⬇️
src/pwf2dict.jl 96.29% <91.30%> (+0.03%) ⬆️
src/pwf2pm/bus.jl 95.00% <100.00%> (ø)
src/pwf2pm/correct/anarede.jl 69.64% <100.00%> (ø)
src/pwf2pm/correct/organon.jl 93.75% <100.00%> (ø)
src/pwf2pm/dcline.jl 98.75% <100.00%> (ø)
src/pwf2pm/gen.jl 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8a35e...0fc5fb3. Read the comment docs.

@PHamacher PHamacher merged commit 974c765 into develop Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate error for ESS ImperatrizPS file in DBAR section Improve warnings Use Memento to handle logs
2 participants