Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tap control and shunts #36

Merged
merged 3 commits into from
May 22, 2022
Merged

Adjust tap control and shunts #36

merged 3 commits into from
May 22, 2022

Conversation

PHamacher
Copy link
Collaborator

Fixes issues #33 and #35

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #36 (02b2b25) into develop (be6a7f4) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage    90.68%   91.33%   +0.64%     
===========================================
  Files           14       14              
  Lines         1074     1062      -12     
===========================================
- Hits           974      970       -4     
+ Misses         100       92       -8     
Impacted Files Coverage Δ
src/pwf2pm/bus.jl 95.12% <100.00%> (+0.12%) ⬆️
src/pwf2pm/shunt.jl 94.82% <100.00%> (+5.19%) ⬆️
src/pwf2pm/transformer.jl 98.38% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6a7f4...02b2b25. Read the comment docs.

@PHamacher PHamacher requested a review from iagochavarry May 20, 2022 20:36
@iagochavarry iagochavarry merged commit 373dc41 into develop May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tap_control data into Bus section Model individually each shunt element instead of aggregating them
2 participants