Lot's of warning from signed versus unsigned integer comparisons

[twongjirad]

Compiling Reco3D produces a lot of warnings like below. Note super urgent, but please fix these. Either by changing iterator to size_t or casting output of x.size() with (int)x.size(). This will help make compilation debugging easier.

ReadRuiFile.cxx: In member function ‘virtual bool larcv::ReadRuiFile::process(larcv::IOManager&)’:
ReadRuiFile.cxx:101:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int iMC = 0;iMC<mc_roi_v.size();iMC++){
~~~^~~~~~~~~~~~~~~~
ReadRuiFile.cxx:124:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int iProton = 0;iProton<ProtonVertices.size();iProton++){
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
ReadRuiFile.cxx:128:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int iMuon = 0;iMuon<MuonVertices.size();iMuon++){
~~~~~^~~~~~~~~~~~~~~~~~~~
ReadRuiFile.cxx:131:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int iElectron = 0;iElectron<ElectronVertices.size();iElectron++){
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
ReadRuiFile.cxx:139:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int imu = 0;imu<goodMuon.size();imu++){
~~~^~~~~~~~~~~~~~~~
ReadRuiFile.cxx:144:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int ie = 0;ie<goodElectron.size();ie++){
~~^~~~~~~~~~~~~~~~~~~~
ReadRuiFile.cxx:187:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int iPoint = 0;iPoint<EndPoints.size();iPoint++){
~~~~~~^~~~~~~~~~~~~~~~~
ReadRuiFile.cxx: In member function ‘bool larcv::ReadRuiFile::IsGoodVertex(int, int, int, int, int)’:
ReadRuiFile.cxx:204:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int ivertex = 0;ivertex<_vertexInfo.size();ivertex++){

[hourlier]

Taritree, I didn't see these warning pop out when I compiled...
I changed anyway, could you give it a try now? to see if it's better with your compiler?

[drinkingkazu]

“I didn’t see these warnings pop out when I compiled…” => just because of a compiler flags (not even because of versions). You can change default flags or test your code on linux. Ubuntu usually gets you most explicit warnings. Just FYI, this is very typical and well known.

…

On Oct 5, 2017, at 12:40 PM, hourlier ***@***.***> wrote: Taritree, I didn't see these warning pop out when I compiled... I changed anyway, could you give it a try now? to see if it's better with your compiler? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#94 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEgL3o-Io4XyMCf0WrgnYT3dkhHKhiQrks5spTCVgaJpZM4PulQ_>.